Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure support for little endian without 'Exif\0\0' prefix #35

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

lovell
Copy link
Collaborator

@lovell lovell commented Jan 27, 2024

Little endian EXIF without the Exif\0\0 prefix is currently being ignored as the 3rd/4th bytes will be hex 2a00 rather than (big endian) 002a.

sharp v0.33.0 onwards supports EXIF in PNG, defaulting to little endian without prefix, hence this problem appearing now.

The test file was created via:

  .withExif({
    IFD0: {
      Software: "sharp"
    }
  })

This should address #34

@Profesor08
Copy link

Just patched locally with patch-package, and it work well. It woll be great to be merged and published.

@lovell lovell merged commit 4ca59e2 into devongovett:master Jan 28, 2024
1 check passed
@lovell lovell deleted the fix-little-endian-without-trailer branch January 28, 2024 16:31
@lovell lovell mentioned this pull request Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants