-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#522 :update devon4j to 2020.12.002 #525
#522 :update devon4j to 2020.12.002 #525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suvmanda Excellent. This is looking very good. 👍
I just merged your PR in ide-settings
. Can you include the submodule update into this PR to fix the travis build?
Also there are two other version updates missing from the PR I linked:
<guava.version>30.0-jre</guava.version>
<junit.version>5.7.0</junit.version>
Can you please add them as well?
devonfw#522:update guava version and junit version
Sorry, my mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suvmanda Thanks for your updates. Now travis is green and all is perfect. 👍
FYI: I removed the line with the junit.version
update as it was my mistake to suggest it:
In #272 we wanted to migrate projects automatically from juni4
to junit5
and we figured out that this migration is too complex and we will not be able to provide this in a reliable way. So we decided not to force projects to uprade to junit5
as the added value is limited while the effort may be high for the project.
As junit
is a test-tool, CVEs and security updates do not have the highest priority and projects can do that themselves as needed. So for simplicity lets avoid having advanced logic that only updates to the latest junit
version 5.7.0
if the current junit
version is starting with 5.
.
Implements #522