Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#522 :update devon4j to 2020.12.002 #525

Conversation

suvmanda
Copy link
Contributor

@suvmanda suvmanda commented Jan 28, 2021

Implements #522

@suvmanda suvmanda requested a review from hohwille January 28, 2021 11:00
@hohwille hohwille added this to the release:2020.12.002 milestone Jan 28, 2021
@hohwille hohwille added enhancement New feature or request java related to Java code, the Java Virtual Machine and directly related tooling (OpenJDK, Adoptium) migator related to devon4j project migrator feature (devon java migrate ...) update related to updating software or the entire devonfw-ide labels Jan 28, 2021
@hohwille hohwille linked an issue Jan 28, 2021 that may be closed by this pull request
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suvmanda Excellent. This is looking very good. 👍
I just merged your PR in ide-settings. Can you include the submodule update into this PR to fix the travis build?
Also there are two other version updates missing from the PR I linked:

   <guava.version>30.0-jre</guava.version>
    <junit.version>5.7.0</junit.version>

Can you please add them as well?

@suvmanda suvmanda requested a review from hohwille January 29, 2021 10:24
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suvmanda Thanks for your updates. Now travis is green and all is perfect. 👍

FYI: I removed the line with the junit.version update as it was my mistake to suggest it:
In #272 we wanted to migrate projects automatically from juni4 to junit5 and we figured out that this migration is too complex and we will not be able to provide this in a reliable way. So we decided not to force projects to uprade to junit5 as the added value is limited while the effort may be high for the project.
As junit is a test-tool, CVEs and security updates do not have the highest priority and projects can do that themselves as needed. So for simplicity lets avoid having advanced logic that only updates to the latest junit version 5.7.0 if the current junit version is starting with 5..

@hohwille hohwille merged commit a07776f into devonfw:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request java related to Java code, the Java Virtual Machine and directly related tooling (OpenJDK, Adoptium) migator related to devon4j project migrator feature (devon java migrate ...) update related to updating software or the entire devonfw-ide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update devon4j to 2020.12.002 and create migration to this version
2 participants