Rework of devon4j-batch module #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New examples are available in devonfw/my-thai-star#321 |
maihacke
changed the title
maihacke
changed the title
maihacke
changed the title
hohwille
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
@maihacke Thanks for this PR. Looks reasonable to me. 👍
So in general approved.
However, could you please have a look at the comments and do some nice2have improvements. Also it seems as both this PR and PR #199 seem to change the guide-batch-layer in the same or similar way and might conflict with each other.
...les/batch/src/main/java/com/devonfw/module/batch/common/base/SpringBootBatchCommandLine.java
Outdated
Show resolved
Hide resolved
...les/batch/src/main/java/com/devonfw/module/batch/common/base/SpringBootBatchCommandLine.java
Show resolved
Hide resolved
.../java/com/devonfw/module/batch/common/impl/JobLauncherWithAdditionalRestartCapabilities.java
Outdated
Show resolved
Hide resolved
hohwille
added
batch
maihacke
changed the title
|
As soon as we have merged this, we should rework the devon4j-template. |
CommandLineJobRunner, which also loads jobs by bean name. Also the injection of required spring batch-beans as been aligned with CommandLineJobRunner.
…quired. Cleanup and documentation.
|
Rebased this PR to resolve conflicts, everything should be finde now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework how jobs are loaded from context (see #190). Made it more similar to SpringsCommandLineJobRunner, which also loads jobs by bean name.
Also the injection of required spring batch-beans as been aligned with
CommandLineJobRunner.