Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken link for access-control-schema #318

Closed
maybeec opened this issue Dec 9, 2020 · 2 comments · Fixed by #331
Closed

broken link for access-control-schema #318

maybeec opened this issue Dec 9, 2020 · 2 comments · Fixed by #331
Labels
bug Something isn't working documentation Guides, tutorials, readmes, etc. easyfix Good for newcomers
Milestone
release:2020.12.002

Comments

@maybeec
Copy link
Member

maybeec commented Dec 9, 2020

Expected behavior

As a user, I want to read about access-control-schema so that I can implement an easy potentially temporary solution for my authorization.

Actual behavior

Finding this spot https://devonfw.com/website/pages/docs/devon4j.asciidoc_guides.html#guide-access-control.asciidoc_access-control-schema-deprecated the link to the access-control-schema docs is broken.
@maybeec maybeec added bug Something isn't working documentation Guides, tutorials, readmes, etc. easyfix Good for newcomers labels Dec 9, 2020
@hohwille
Copy link
Member

@maybeec thanks for the issue.
Like with #319 we have the same problem here: The website generation is broken and not devon4j. It works perfectly well and we are using proper AsciiDoc:
https://github.com/devonfw/devon4j/blob/develop/documentation/guide-access-control.asciidoc#access-control-schema-deprecated

@hohwille hohwille added this to the rejected milestone Dec 10, 2020
maybeec added a commit that referenced this issue Dec 25, 2020
@maybeec
add missing guide
edc9eef 
fixing #318
@maybeec maybeec mentioned this issue Dec 25, 2020
Merged
hohwille pushed a commit that referenced this issue Jan 7, 2021
@maybeec
#318: add missing guide-access-control-schema (#331)
c2396e7
@hohwille hohwille linked a pull request Jan 7, 2021 that will close this issue
add missing guide-access-control-schema #331
Merged
@hohwille hohwille modified the milestones: rejected, release:2020.12.002 Jan 7, 2021
@hohwille
Copy link
Member

hohwille commented Jan 7, 2021

Sorry for rejecting too quickly last year in the hustle and thanks so much for fixing via PR.
As PR is merged, I am closing now.

@hohwille hohwille closed this as completed Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Guides, tutorials, readmes, etc. easyfix Good for newcomers
Projects
None yet
Milestone
release:2020.12.002
Development

Successfully merging a pull request may close this issue.

add missing guide-access-control-schema devonfw/devon4j
2 participants
@maybeec @hohwille