-
-
Notifications
You must be signed in to change notification settings - Fork 7
Fix regex pattern to handle clickable image badges with relative URLs #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: kzu <[email protected]>
Co-authored-by: kzu <[email protected]>
This reverts commit 36afa4e.
🧪 Details on Microsoft Windows 10.0.26100from dotnet-retest v1.0.0 on .NET 9.0.9 with 💜 by @devlooped |
|
@copilot there seems to be an unrelated test failure in the CI build: perhaps try updating that to .net 10? |
…formVersion Add SupportedOSPlatformVersion of 14.0 for net8.0-maccatalyst to fix the build error: "1.0 is not a valid TargetPlatformVersion for maccatalyst" Co-authored-by: kzu <[email protected]>
... Fixed in commit |
Head branch was pushed to by a user without write access
Summary
Fixed the issue where relative links in clickable image badges were not being replaced with full URLs during package creation.
Changes Made
File:
src/NuGetizer.Tasks/CreatePackage.cs[^\]]+to!\[[^\]]*\]\([^\)]*\)|[^\]]+to properly match nested bracketsFile:
src/NuGetizer.Tests/CreatePackageTests.cswhen_readme_has_clickable_image_badge_with_relative_url_then_replaces_url()to verify the fixFile:
src/NuGetizer.Tests/Scenarios/given_multitargeting_libraries/uilibrary.csprojSupportedOSPlatformVersionof 14.0 for maccatalyst to fix CI build errorVerification
✅ Both examples from the issue now work correctly:
[](osmfeula.txt)→ relative URL is replaced[](license.txt)→ relative URL is replaced✅ All existing test scenarios still work:
[text](url)[text](url "title")✅ Fixed unrelated CI test failure for maccatalyst platform version
Original prompt
Fixes #656
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.