Never pack NuGetizer transitively #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stops inference from collecting transitive dependency files from NuGetizer and packing them too alongisde the consuming project. This is currently an issue since due to being a development dependency, NuGetizer will by default install with a `PrivateAssets=all` value, which for packing purposes means "pack everything this dependency brings, transitively, into this package output", since that's the most common scenario. But for build-only packages like NuGetizer, it doesn't make sense. Especially for non-build transitive assets such as analyzer's localization files (i.e. SponsorLink in NuGetizer's case). So we default this to the most obvious value now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops inference from collecting transitive dependency files from NuGetizer and packing them too alongisde the consuming project.
This is currently an issue since due to being a development dependency, NuGetizer will by default install with a
PrivateAssets=allvalue, which for packing purposes means "pack everything this dependency brings, transitively, into this package output", since that's the most common scenario.But for build-only packages like NuGetizer, it doesn't make sense. Especially for non-build transitive assets such as analyzer's localization files (i.e. SponsorLink in NuGetizer's case).
So we default this to the most obvious value now.