Fix nugetize tool for solutions that use project dependencies #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Project dependencies is a mechanism to affect the build order in a solution without adding project references. See https://www.cazzulino.com/project-dependencies-as-project-references.html. In this scenario, MSBuild will emit a .metaproj for the solution and *also* a .metaproj for each project that declares such dependencies, which in turn uses project references for the dependencies *and* the original project. This generated .metaproj, obviously, won't have any of the standard targets, not even GetTargetPath, which means we won't be able to even determine if the project is nugetized or not. This used to cause the nugetize tool to refuse to process the other projects in a solution. This change removes such meta projects from the solution so that the other projects can still work. Note that this may result in missing (packable) projects, but the benefit is that you get *some* rendering at least. You can always run nugetize passing the missing projects' contents, but the current experience is clearly far worse than that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project dependencies is a mechanism to affect the build order in a solution without adding project references. See https://www.cazzulino.com/project-dependencies-as-project-references.html.
In this scenario, MSBuild will emit a .metaproj for the solution and also a .metaproj for each project that declares such dependencies, which in turn uses project references for the dependencies and the original project. This generated .metaproj, obviously, won't have any of the standard targets, not even GetTargetPath, which means we won't be able to even determine if the project is nugetized or not.
This used to cause the nugetize tool to refuse to process the other projects in a solution.
This change removes such meta projects from the solution so that the other projects can still work. Note that this may result in missing (packable) projects, but the benefit is that you get some rendering at least. You can always run nugetize passing the missing projects' contents, but the current experience is clearly far worse than that.