Fix git read cache race condition

Continue on error as same as no cache.
devlooped · Feb 6, 2024 · 06626f6 · 06626f6
1 parent 8490a53
commit 06626f6
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/GitInfo/build/GitInfo.targets b/src/GitInfo/build/GitInfo.targets
@@ -384,12 +384,12 @@
     <Delete Files="$(_GitInfoFile)" />
   </Target>
 
-  <Target Name="_GitReadCache" Condition="Exists('$(_GitInfoFile)') And '$(SkipReadGitCache)' != 'true' ">
-    <PropertyGroup>
-      <_GitCachedInfo>$([System.IO.File]::ReadAllText('$(_GitInfoFile)'))</_GitCachedInfo>
-    </PropertyGroup>
+  <Target Name="_GitReadCache" Condition="Exists('$(_GitInfoFile)') And '$(SkipReadGitCache)' != 'true'">
+    <ReadLinesFromFile File="$(_GitInfoFile)" ContinueOnError="true">
+      <Output TaskParameter="Lines" ItemName="_GitCachedInfo" />
+    </ReadLinesFromFile>
 
-    <CreateItem Include="GitInfo" AdditionalMetadata="$(_GitCachedInfo.Split(';'))">
+    <CreateItem Include="GitInfo" AdditionalMetadata="@(_GitCachedInfo -> TrimEnd(';'))">
       <Output TaskParameter="Include" ItemName="GitInfo" />
     </CreateItem>