Fix FSPXI_CreateFile and FSPXI_WriteFile #496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FSPXI_CreateFile: the command buffer at index 9 was assigned twice. See here: https://3dbrew.org/wiki/FSPXI:CreateFile
Creating any file with valid arguments results in 0xD9001830.
Regarding FSPXI_WriteFile: the
size
andflags
are actually swapped. I found this out after some code analysis of the fs codebin.This is what it looks like:
Looking a bit closer, the size and flags are swapped. The same size being used for the buffer descriptor confirms this as well.