Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Remove (object) in class definitions #2378

Merged
merged 2 commits into from
May 29, 2024
Merged

misc: Remove (object) in class definitions #2378

merged 2 commits into from
May 29, 2024

Conversation

EdCaunt
Copy link
Contributor

@EdCaunt EdCaunt commented May 28, 2024

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove it from:

class xxxx(object, yyy)?

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 91.71598% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 86.81%. Comparing base (ffd8ee0) to head (cf509f9).

Files Patch % Lines
tests/test_gpu_common.py 0.00% 8 Missing ⚠️
tests/test_gpu_openacc.py 0.00% 3 Missing ⚠️
tests/test_gpu_openmp.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2378   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files         233      233           
  Lines       43759    43759           
  Branches     8076     8076           
=======================================
  Hits        37990    37990           
  Misses       5061     5061           
  Partials      708      708           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FabioLuporini FabioLuporini merged commit 602d5e6 into master May 29, 2024
31 checks passed
@FabioLuporini FabioLuporini deleted the object branch May 29, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants