compiler: Make code gen of elementary funcs dtype-aware #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabioLuporini
added
the
bug-C-minor
georgebisbas
approved these changes
Apr 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2349 +/- ##
=======================================
Coverage 79.44% 79.44%
=======================================
Files 232 232
Lines 43587 43607 +20
Branches 8070 8072 +2
=======================================
+ Hits 34629 34645 +16
- Misses 8202 8206 +4
Partials 756 756 ☔ View full report in Codecov by Sentry. |
mloubout
reviewed
Apr 11, 2024
| @@ -255,6 +274,11 @@ def _print_Fallback(self, expr): | |||
| _print_Basic = _print_Fallback | |||
|
|
|||
|
|
|||
| # Lifted from SymPy so that we go through our own `_print_math_func` | |||
| for k in ('exp log sin cos tan ceiling floor').split(): | |||
There was a problem hiding this comment.
Isn't it ceil not ceiling
There was a problem hiding this comment.
somehow it gets remapped internally...
https://github.com/sympy/sympy/blob/master/sympy/printing/c.py#L734
FabioLuporini
force-pushed
the
fix-elementary-dtype
branch
from
c485da5 to
3c8edea
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cos(np.float32)now generatescosf(...)