Correct the Poisson equation in the cavity flow example #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mloubout
approved these changes
Feb 12, 2024
|
Good catch, thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2308 +/- ##
=======================================
Coverage 86.71% 86.71%
=======================================
Files 229 229
Lines 42958 42958
Branches 7958 7958
=======================================
+ Hits 37251 37253 +2
+ Misses 5023 5021 -2
Partials 684 684 ☔ View full report in Codecov by Sentry. |
EdCaunt
reviewed
Feb 12, 2024
| @@ -474,7 +474,7 @@ | |||
| "# First order derivatives will be handled with p.dxc\n", | |||
| "eq_u =Eq(u.dt + u*u.dx + v*u.dy, -1./rho * p.dxc + nu*(u.laplace), subdomain=grid.interior)\n", | |||
| "eq_v =Eq(v.dt + u*v.dx + v*v.dy, -1./rho * p.dyc + nu*(v.laplace), subdomain=grid.interior)\n", | |||
| "eq_p =Eq(p.laplace,rho*(1./dt*(u.dxc+v.dyc)-(u.dxc*u.dxc)+2*(u.dyc*v.dxc)+(v.dyc*v.dyc)), subdomain=grid.interior)\n", | |||
| "eq_p =Eq(p.laplace,rho*(1./dt*(u.dxc+v.dyc)-(u.dxc*u.dxc)-2*(u.dyc*v.dxc)-(v.dyc*v.dyc)), subdomain=grid.interior)\n", | |||
There was a problem hiding this comment.
There's also a missing space around the equals here right (unless it's rendering weird on my laptop)? Would it be possible to tag that onto the PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a sign mistake in the Poisson equation. It doesn't significantly affect the solution of this particular example, but it can be important when solving Navier Stokes for other problems.