misc: Switch off develop-mode #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2280 +/- ##
==========================================
- Coverage 86.82% 86.82% -0.01%
==========================================
Files 229 229
Lines 42441 42453 +12
Branches 7868 7876 +8
==========================================
+ Hits 36851 36859 +8
- Misses 4931 4941 +10
+ Partials 659 653 -6 ☔ View full report in Codecov by Sentry. |
FabioLuporini
force-pushed
the
develop-mode-off
branch
from
cb95673 to
f9759ae
Compare
EdCaunt
reviewed
Dec 11, 2023
| configuration.add('develop-mode', True, [False, True]) | ||
| # - The ALLOC_GUARD data allocator is used. This will trigger segfaults as soon | ||
| # as an out-of-bounds memory access is performed | ||
| # - Some autoi-tuning optimizations are disabled |
ggorman
reviewed
Dec 11, 2023
| @@ -7,7 +7,7 @@ | |||
| from devito.core.autotuning import options # noqa | |||
|
|
|||
|
|
|||
| @switchconfig(log_level='DEBUG') | |||
| @switchconfig(log_level='DEBUG', develop_mode=True) | |||
There was a problem hiding this comment.
It needs to be documented that setting log_level='DEBUG' also turns on develop_mode.
Also, as ALLOC_GUARD can cause incorrect behavior when data streaming with an accelerator, shouldn't there be an additional check to ensure it's not enabled in that case?
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
georgebisbas
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a legacy thing. Pointless.
In fact, potentially harmful for data transfer performance since aligned based addresses will result in higher performance with most device backends