mpi: Fix haloupdate with inner dim #2264
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2264 +/- ##
==========================================
- Coverage 86.92% 77.76% -9.17%
==========================================
Files 229 229
Lines 42150 42230 +80
Branches 7787 7802 +15
==========================================
- Hits 36639 32839 -3800
- Misses 4863 8694 +3831
- Partials 648 697 +49 ☔ View full report in Codecov by Sentry. |
mloubout
force-pushed
the
halo-inner-dim
branch
from
c429c7e to
ea02453
Compare
mloubout
force-pushed
the
halo-inner-dim
branch
from
ea02453 to
3ef0603
Compare
| else: | ||
| hispace = None | ||
|
|
||
| if hispace and options['mpi']: |
There was a problem hiding this comment.
@FabioLuporini replying to your comment in the other PR
We only check options['mpi'] here to avoid creating empty loops without mpi since the haloupdate is then dropped, the halo is still attached the normal way in the else when options['mpi'] = False so it's still there.
FabioLuporini
changed the title
tests/test_mpi.py
Outdated
| @@ -601,6 +602,94 @@ def test_precomputed_sparse(self, r): | |||
| Operator(sf1.interpolate(u))() | |||
| assert np.all(sf1.data == 4) | |||
|
|
|||
| @pytest.mark.parallel(mode=1) | |||
There was a problem hiding this comment.
memo for me: probably mode=4
tests/test_mpi.py
Outdated
| op.apply() | ||
| assert np.all(s.data == 1) | ||
|
|
||
| @pytest.mark.parallel(mode=1) |
tests/test_mpi.py
Outdated
| @pytest.mark.parallel(mode=1) | ||
| def test_sparse_first(self): | ||
| """ | ||
| Tests custom sprase function with sparse dimension as first index. |
tests/test_mpi.py
Outdated
| """ | ||
|
|
||
| class SparseFirst(SparseFunction): | ||
| """ Custom sparse class with the sparse dimension as the first one""" |
There was a problem hiding this comment.
Space floating around at start of docstring
mloubout
force-pushed
the
halo-inner-dim
branch
from
3ef0603 to
f37445e
Compare
|
superseded by #2272 , closing |
Fixes #2262