compiler: Patch symbolic coefficients over cross derivatives #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2248 +/- ##
==========================================
+ Coverage 86.88% 86.90% +0.02%
==========================================
Files 229 229
Lines 41691 41759 +68
Branches 7696 7703 +7
==========================================
+ Hits 36223 36292 +69
- Misses 4839 4840 +1
+ Partials 629 627 -2
|
EdCaunt
reviewed
Oct 26, 2023
| @@ -22,7 +22,7 @@ def test_backward_dt2(self): | |||
| assert_structure(op, ['t,x,y'], 't,x,y') | |||
|
|
|||
|
|
|||
| class TestSymbolicCoefficients(object): | |||
| class TestSymbolicCoeffs(object): | |||
There was a problem hiding this comment.
Think we should also test the case where different coefficients are passed for x and y derivatives with cross-derivatives, mixed derivatives, and non-perfect mixed derivatives. Also the case where only one of the x or y derivatives gets coefficients specified but bother are defined as symbolic.
EdCaunt
reviewed
Oct 26, 2023
| Operator(Eq(u, u.dx.dx, coefficients=coeffs), opt=opt).cfunction | ||
|
|
||
| # Non-perfect mixed derivative | ||
| Operator(Eq(u, (u.dx + v.dx).dx, coefficients=coeffs), opt=opt).cfunction |
There was a problem hiding this comment.
Need to sanity check these outputs. Print them and you will see that no errors are raised currently, but the resultant stencils are incorrect
EdCaunt
approved these changes
Oct 27, 2023
…tom coefficients with nested expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.