dsl: Patch domain decomposition bug with SubDomains #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2246 +/- ##
=======================================
Coverage 86.90% 86.91%
=======================================
Files 229 229
Lines 41759 41790 +31
Branches 7703 7709 +6
=======================================
+ Hits 36292 36323 +31
Misses 4840 4840
Partials 627 627
|
mloubout
reviewed
Oct 26, 2023
tests/test_subdomains.py
Outdated
| @@ -162,6 +162,66 @@ def define(self, dimensions): | |||
|
|
|||
| assert u0.data.all() == u1.data.all() == u2.data.all() == u3.data.all() | |||
|
|
|||
| sd_specs = [None, ('middle', 1, 7), ('middle', 2, 3), ('middle', 7, 1), | |||
There was a problem hiding this comment.
Need a ('middle', 5, 5) case for the case it's fully contained in the center domain and make sure you have 3 domains along that dimension
mloubout
approved these changes
Oct 27, 2023
EdCaunt
force-pushed
the
subdim-mpi-fix
branch
from
df05fb3 to
367bb1d
Compare
types: subdimension bounds, decomposition handling tests: Added test for SubDomains and domain decomposition tests: Removed unnecessary MPI mode specification tests: Added diagnostic print statements tests: Fixed diagnostic print statements tests: fixed occasional None in substitution tests: Fixed typo tests: Made Subdomain + MPI data check global rather than per-rank tests: Removed unecessary complexity from MPI + SubDomains test
mloubout
force-pushed
the
subdim-mpi-fix
branch
from
367bb1d to
5f026de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.