compiler: Add host-*-pin handles; more volatile with pthreads #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2116 +/- ##
==========================================
- Coverage 87.75% 87.71% -0.04%
==========================================
Files 221 221
Lines 39010 39030 +20
Branches 5068 5075 +7
==========================================
+ Hits 34233 34236 +3
- Misses 4215 4232 +17
Partials 562 562
|
FabioLuporini
changed the title
| if obj is candidate: | ||
| return True | ||
|
|
||
| # Names are unique throughout compilation, so this is another case we can handle |
| def sanitize_ncfields(ncfields): | ||
| # Due to a bug in the NVC compiler (v<=22.7 and potentially later), | ||
| # we have to use C's `volatile` more extensively than strictly necessary | ||
| # to avoid flaky optimizations that would cause fauly behaviour in rare, |
mloubout
reviewed
Apr 27, 2023
| if obj.name == candidate.name: | ||
| return True | ||
|
|
||
| if obj.is_AbstractFunction: |
There was a problem hiding this comment.
Are these case really needed? Will obviously always return false passed this line no matter
There was a problem hiding this comment.
not strictly speaking and not today, but they were in the back of my mind already, so I put them there for the future
FabioLuporini
force-pushed
the
enable-parlang-overrides
branch
from
0c3ec62 to
63e57c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.