Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symbolics: evaluate transpose on elements of tensors in case of deriv… #2072

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

mloubout
Copy link
Contributor

Fixes #2071

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #2072 (2edeac6) into master (1d4b9ca) will increase coverage by 0.00%.
The diff coverage is 96.77%.

@@           Coverage Diff           @@
##           master    #2072   +/-   ##
=======================================
  Coverage   87.78%   87.79%           
=======================================
  Files         224      224           
  Lines       38711    38740   +29     
  Branches     5821     5826    +5     
=======================================
+ Hits        33982    34011   +29     
- Misses       4177     4179    +2     
+ Partials      552      550    -2     
Impacted Files Coverage Δ
devito/types/basic.py 93.77% <85.71%> (-0.09%) ⬇️
examples/seismic/elastic/operators.py 100.00% <100.00%> (ø)
examples/seismic/viscoelastic/operators.py 100.00% <100.00%> (ø)
tests/test_tensors.py 94.68% <100.00%> (+0.63%) ⬆️
devito/ir/support/basic.py 92.79% <0.00%> (-0.19%) ⬇️
devito/finite_differences/derivative.py 96.51% <0.00%> (+1.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mloubout mloubout force-pushed the tens-transp branch 2 times, most recently from 988aad6 to 488e756 Compare March 1, 2023 14:33
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mloubout mloubout force-pushed the tens-transp branch 2 times, most recently from a69f313 to d2cb78c Compare March 2, 2023 12:42
Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncontroversial

@mloubout mloubout merged commit a2518b7 into master Mar 6, 2023
@mloubout mloubout deleted the tens-transp branch March 6, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transpose of the gradient of scalar field not performing inner transposition
2 participants