compiler: Patch data dependencies across Jumps #2065
Conversation
| mock = f.indexify(indices) | ||
| try: | ||
| mock = f.indexify(indices) | ||
| except IndexException: |
There was a problem hiding this comment.
What would make this fail? Bad indices?
There was a problem hiding this comment.
yeah just empty indices, trivial sympy exception when you attempt to create an Indexed w/o supplying indices 😬
There was a problem hiding this comment.
Should you add some related message or failing test?
There was a problem hiding this comment.
Definitely not a message; probably a unit test...
However, creating an artificial case exciting this code path here w/o PRO will take O(hour) time, which I don't have, so given that this is a minuscule thing and that, after all, we do have a test exciting this in PRO, despite agreeing w/ you this ain't ideal, I suggest we proceed
| mock = f.indexify(indices) | ||
| try: | ||
| mock = f.indexify(indices) | ||
| except IndexException: |
There was a problem hiding this comment.
Should you add some related message or failing test?
Codecov Report
@@ Coverage Diff @@
## master #2065 +/- ##
==========================================
- Coverage 87.78% 87.77% -0.01%
==========================================
Files 224 224
Lines 38653 38657 +4
Branches 5816 5816
==========================================
+ Hits 33930 33931 +1
- Misses 4173 4177 +4
+ Partials 550 549 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
No description provided.