Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update compiler summary image #2037

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Conversation

georgebisbas
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -8,7 +8,7 @@
"\n",
"In Devito, an `Operator` carries out three fundamental tasks: generation of low-level code, JIT compilation, and execution. Overall, the lowering process performed by an `Operator` – from high-level equations to dynamically compiled and executable code – consists of multiple compiler passes, summarized in the Figure bellow. The following series of notebooks will describe these compilation passes in a hands-on fashion. We will explore the heart of the `Operator` class, which orchestrates code generation and compilation. For more details, see the [Operator class](https://github.com/devitocodes/devito/blob/master/devito/operator/operator.py).\n",
"\n",
"![compiler-stages](https://user-images.githubusercontent.com/478143/57969349-6a6ad980-7976-11e9-89ae-8866e383e2e9.png)\n",
"![compiler-stages](https://raw.githubusercontent.com/gist/georgebisbas/cab358b6ee2c834c1eb7100dabf832de/raw/bfbe3ba8cc8ce6d58c57eebd39941b5868ffd942/devito-outline-4.7.svg)\n",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it as a GH gist under version control, lemme know for any better alternatives or If I should put in some place in the org

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably do what we usually do for these static images and just put the SVG in the repo. That's what we do for fixed png s in the seismic tutorials

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #2037 (bea5580) into master (4cc9165) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2037      +/-   ##
==========================================
- Coverage   87.85%   87.85%   -0.01%     
==========================================
  Files         214      214              
  Lines       37327    37327              
  Branches     5627     5627              
==========================================
- Hits        32794    32793       -1     
- Misses       4007     4009       +2     
+ Partials      526      525       -1     
Impacted Files Coverage Δ
devito/ir/support/basic.py 92.38% <0.00%> (-0.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncontroversial, thanks

@FabioLuporini FabioLuporini merged commit 30cad76 into master Nov 29, 2022
@FabioLuporini FabioLuporini deleted the compiler_diagram_refresh branch November 29, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants