compiler: Infer type generation from _C_ctype #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
FabioLuporini
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1971 +/- ##
=======================================
Coverage 87.88% 87.88%
=======================================
Files 213 213
Lines 36196 36175 -21
Branches 5449 5459 +10
=======================================
- Hits 31810 31793 -17
+ Misses 3877 3867 -10
- Partials 509 515 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. |
FabioLuporini
commented
Jul 23, 2022
| _C_field_nbytes = 'nbytes' | ||
| _C_field_dmap = 'dmap' | ||
|
|
||
| _C_ctype = POINTER(type(_C_structname, (Structure,), |
There was a problem hiding this comment.
you see? a ney symbolic type, ArrayMapped, but the only thing that needs to be defined is the _C_ctype. This is enough to create a ctype, a str representing its C type, etc etc.
FabioLuporini
commented
Jul 23, 2022
| @@ -1269,120 +1269,6 @@ def test_loose_kwargs(self): | |||
| @skipif('device') | |||
| class TestDeclarator(object): | |||
|
|
|||
| def test_heap_1D(self): | |||
There was a problem hiding this comment.
all these tests were obsolete, a massive PITA to maintain, and basically unnecessary. Hence, dropping
|
|
||
| def ctypes_to_cgen(ctype, fields=None): | ||
| """ | ||
| Create a cgen.Structure off a ctypes.Struct, or (possibly nested) ctypes.Pointer |
FabioLuporini
force-pushed
the
array-struct
branch
from
2dab961 to
1619f80
Compare
FabioLuporini
force-pushed
the
array-struct
branch
from
1619f80 to
d29d57d
Compare
FabioLuporini
force-pushed
the
array-struct
branch
from
d29d57d to
9a5e60d
Compare
georgebisbas
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeSymbol subclasses were required to override a subset of
_C_typedata,_C_typename,_C_typedecl,_C_ctype. This was messy, difficult to understand, challenging to maintain, and also a bit hacky.Now CodeSymbol subclasses are only requested to specialize
_C_ctype. All other information are derived from_C_ctypethrough suitable utility functions (e.g., astrrepresentation of the C type for code generation will be generated via the utilityctypes_to_cstr).This is in my opinion a remarkable improvement to the codegen infrastracture, that was long due.
The
ArrayMappedtype is also introduced.