Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: Support interpolation with user-provided implicit dims #1948

Merged
merged 1 commit into from
Jul 17, 2022
Merged

compiler: Support interpolation with user-provided implicit dims #1948

merged 1 commit into from
Jul 17, 2022

Conversation

FabioLuporini
Copy link
Contributor

@FabioLuporini FabioLuporini commented Jun 22, 2022 •
edited
Loading

TODO: add a reasonable assert to the added test

@FabioLuporini FabioLuporini added the API api (symbolics, types, ...) label Jun 22, 2022
@codecov
Copy link

codecov bot commented Jun 22, 2022 •
edited
Loading

Codecov Report

Merging #1948 (2f96bfb) into master (2f96bfb) will not change coverage.
The diff coverage is n/a.

❗ Current head 2f96bfb differs from pull request most recent head ea8b9c3. Consider uploading reports for the commit ea8b9c3 to get more accurate results

@@           Coverage Diff           @@
##           master    #1948   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files         211      211           
  Lines       36099    36099           
  Branches     5430     5430           
=======================================
  Hits        31569    31569           
  Misses       4024     4024           
  Partials      506      506

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f96bfb...ea8b9c3. Read the comment docs.

@FabioLuporini FabioLuporini force-pushed the patch-conddim-sparse branch from 30d34ac to 2864818 Compare June 23, 2022 07:48
jkwashbourne
jkwashbourne approved these changes Jun 23, 2022
View reviewed changes
Copy link
Collaborator

@jkwashbourne jkwashbourne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@mloubout mloubout force-pushed the patch-conddim-sparse branch from 2864818 to ea8b9c3 Compare July 16, 2022 23:04
@mloubout mloubout merged commit d9df3b1 into master Jul 17, 2022
@mloubout mloubout deleted the patch-conddim-sparse branch July 17, 2022 01:22
@AtilaSaraiva AtilaSaraiva mentioned this pull request Aug 16, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwashbourne jkwashbourne jkwashbourne approved these changes

@georgebisbas georgebisbas georgebisbas approved these changes

@mloubout mloubout mloubout approved these changes

Assignees
No one assigned
Labels
API api (symbolics, types, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FabioLuporini @mloubout @georgebisbas @jkwashbourne