examples: Update attribute names and backend for synthetics notebook #1895
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #1895 +/- ##
=======================================
Coverage 89.63% 89.63%
=======================================
Files 210 210
Lines 35265 35265
Branches 5319 5319
=======================================
Hits 31611 31611
Misses 3161 3161
Partials 493 493 Continue to review full report at Codecov.
|
| @@ -48,7 +48,8 @@ | |||
| "name": "stdout", | |||
There was a problem hiding this comment.
Line #24. try:
Should we have version check for all python packages?
Maybe you could also try to see whether newer pyvista or gempy versions can be available?
Reply via ReviewNB
| @@ -48,7 +48,8 @@ | |||
| "name": "stdout", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah, not sure why that's not showing up. It displays locally. Might be some interplay between the new vtk notebook backend and nbreview?
There was a problem hiding this comment.
Looks like it doesn't display on github's notebook reader either, but it gets rid of the warning locally
| @@ -48,7 +48,8 @@ | |||
| "name": "stdout", | |||
There was a problem hiding this comment.
FabioLuporini
changed the title
| @@ -48,7 +48,8 @@ | |||
| "name": "stdout", | |||
There was a problem hiding this comment.
Updated pyvista to use new attribute names and notebook backend in the synthetics notebook. Should hopefully fix the notebook CI failures.