Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: Avoid generating unnecessary conditionals #1880

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

FabioLuporini
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #1880 (d071fce) into master (68d7cf5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1880   +/-   ##
=======================================
  Coverage   89.56%   89.56%           
=======================================
  Files         210      210           
  Lines       35051    35052    +1     
  Branches     5295     5296    +1     
=======================================
+ Hits        31393    31394    +1     
  Misses       3163     3163           
  Partials      495      495           
Impacted Files Coverage Δ
devito/passes/iet/parpragma.py 90.13% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d7cf5...d071fce. Read the comment docs.

Copy link
Contributor

@mloubout mloubout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG. Is there a basic example/test for it or is it for some non trivial case?

Copy link
Contributor

@georgebisbas georgebisbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Mathias for a test, otherwise GTG

@FabioLuporini
Copy link
Contributor Author

I thought I had responded, but my comment not showing up?
Anyway...

or is it for some non trivial case?

The opposite -- this tiny patch is just for super trivial cases and as I said it's just about the aesthetics of the generated code, to avoid generating uselss

if (true)

1 similar comment
@FabioLuporini
Copy link
Contributor Author

I thought I had responded, but my comment not showing up?
Anyway...

or is it for some non trivial case?

The opposite -- this tiny patch is just for super trivial cases and as I said it's just about the aesthetics of the generated code, to avoid generating uselss

if (true)

@FabioLuporini FabioLuporini merged commit 017a65b into master Mar 18, 2022
@FabioLuporini FabioLuporini deleted the offloading-aesthetics branch March 18, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants