-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmarks: custom click type for grid params #1832
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1832 +/- ##
==========================================
- Coverage 89.54% 89.53% -0.01%
==========================================
Files 209 209
Lines 34479 34487 +8
Branches 5206 5209 +3
==========================================
+ Hits 30873 30879 +6
- Misses 3115 3116 +1
- Partials 491 492 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of typo's in the NTuple description:
A floating subtype of click's Tuple that allows inputs with fewer elements.
Instead of accepting only tuples of exact length, this accepts tuples
of length up to the definition size.
Fixed typos |
Fixes issue with mulit-params with latest click and benchmark.
Superseeds #1831 and #1692