Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmarks: custom click type for grid params #1832

Merged
merged 2 commits into from
Feb 1, 2022
Merged

benchmarks: custom click type for grid params #1832

merged 2 commits into from
Feb 1, 2022

Conversation

mloubout
Copy link
Contributor

@mloubout mloubout commented Feb 1, 2022

Fixes issue with mulit-params with latest click and benchmark.

Superseeds #1831 and #1692

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #1832 (676266a) into master (fa20c7c) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1832      +/-   ##
==========================================
- Coverage   89.54%   89.53%   -0.01%     
==========================================
  Files         209      209              
  Lines       34479    34487       +8     
  Branches     5206     5209       +3     
==========================================
+ Hits        30873    30879       +6     
- Misses       3115     3116       +1     
- Partials      491      492       +1     
Impacted Files Coverage Δ
benchmarks/user/benchmark.py 62.85% <75.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa20c7c...676266a. Read the comment docs.

Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link
Contributor

@rhodrin rhodrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of typo's in the NTuple description:

A floating subtype of click's Tuple that allows inputs with fewer elements.
Instead of accepting only tuples of exact length, this accepts tuples
of length up to the definition size.

@mloubout
Copy link
Contributor Author

mloubout commented Feb 1, 2022

Fixed typos

@mloubout mloubout merged commit 7216a27 into master Feb 1, 2022
@mloubout mloubout deleted the clickfix branch February 1, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants