Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ckp: Checkpointing update #1774

Merged
merged 6 commits into from
Oct 13, 2021
Merged

ckp: Checkpointing update #1774

merged 6 commits into from
Oct 13, 2021

Conversation

navjotk
Copy link
Member

@navjotk navjotk commented Oct 7, 2021

  1. Starts to cache prepared arguments on the CheckpointOperator object to reduce the overhead of argument processing every time the operator is called.
  2. Moves checkpointing inside the main Devito folder.

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #1774 (6fa82e3) into master (491baef) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1774      +/-   ##
==========================================
- Coverage   89.47%   89.45%   -0.02%     
==========================================
  Files         208      209       +1     
  Lines       33932    33934       +2     
  Branches     4408     4404       -4     
==========================================
- Hits        30361    30357       -4     
- Misses       3074     3081       +7     
+ Partials      497      496       -1     
Impacted Files Coverage Δ
devito/checkpointing/__init__.py 100.00% <ø> (ø)
devito/__init__.py 93.75% <100.00%> (+0.09%) ⬆️
devito/checkpointing/checkpoint.py 100.00% <100.00%> (ø)
examples/seismic/acoustic/wavesolver.py 100.00% <100.00%> (ø)
examples/seismic/tti/wavesolver.py 98.33% <100.00%> (-0.02%) ⬇️
examples/seismic/viscoacoustic/wavesolver.py 100.00% <100.00%> (ø)
tests/test_checkpointing.py 100.00% <100.00%> (ø)
devito/arch/archinfo.py 42.89% <0.00%> (-4.44%) ⬇️
devito/passes/iet/engine.py 91.52% <0.00%> (-3.89%) ⬇️
devito/arch/compiler.py 54.31% <0.00%> (-2.56%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 491baef...6fa82e3. Read the comment docs.

Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add CheckpointOperator to the user API by adding it to devito/__init__.py

examples/seismic/acoustic/wavesolver.py Outdated Show resolved Hide resolved
@navjotk
Copy link
Member Author

navjotk commented Oct 12, 2021

I have now added the two classes to the user-facing API and updated all examples. I tried to squash the commits but that merge in the middle sent me into git hell for a bit. I quickly reverted and gave up on giving you a clean commit history :)

@navjotk navjotk changed the title [WIP] [RFC] Checkpointing update [RFC] Checkpointing update Oct 12, 2021
@FabioLuporini FabioLuporini changed the title [RFC] Checkpointing update ckp: Checkpointing update Oct 13, 2021
@FabioLuporini FabioLuporini merged commit a7dbdab into master Oct 13, 2021
@FabioLuporini FabioLuporini deleted the ckparguments branch October 13, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants