Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Switch to adjoint time derivative #1706

Merged
merged 2 commits into from
Jun 21, 2021
Merged

Conversation

mloubout
Copy link
Contributor

@mloubout mloubout commented Jun 14, 2021

Switch time derivative positon for the gradient as discussed on slack

tests pas locally so should be green.

@mloubout mloubout added the examples examples label Jun 14, 2021
@mloubout mloubout requested a review from FabioLuporini June 14, 2021 17:45
@mloubout mloubout changed the title examples: witch to adjoint time derivative examples: switch to adjoint time derivative Jun 14, 2021
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #1706 (7521637) into master (87ee495) will decrease coverage by 0.22%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1706      +/-   ##
==========================================
- Coverage   88.85%   88.62%   -0.23%     
==========================================
  Files         208      208              
  Lines       33440    33440              
  Branches     4352     4352              
==========================================
- Hits        29713    29637      -76     
- Misses       3235     3311      +76     
  Partials      492      492              
Impacted Files Coverage Δ
examples/seismic/acoustic/operators.py 96.15% <50.00%> (ø)
examples/seismic/tti/operators.py 97.09% <100.00%> (ø)
tests/test_gpu_openacc.py 56.69% <0.00%> (-40.95%) ⬇️
devito/passes/iet/languages/openacc.py 77.01% <0.00%> (-14.95%) ⬇️
devito/arch/compiler.py 54.95% <0.00%> (-3.20%) ⬇️
devito/types/array.py 93.15% <0.00%> (-0.69%) ⬇️
devito/ir/iet/visitors.py 80.52% <0.00%> (-0.38%) ⬇️
devito/passes/equations/linearity.py 100.00% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87ee495...7521637. Read the comment docs.

@FabioLuporini
Copy link
Contributor

Since this has implications on GPU+data streaming, we should wait for #1702 to land first, which also "fixes" the current mismatching tag issue that is causing the omp offloading job to get scheduled to wampa rather than kimogila

@mloubout
Copy link
Contributor Author

sure

@FabioLuporini FabioLuporini changed the title examples: switch to adjoint time derivative examples: Switch to adjoint time derivative Jun 21, 2021
@FabioLuporini FabioLuporini merged commit f08d12e into master Jun 21, 2021
@FabioLuporini
Copy link
Contributor

Merged, thanks

@FabioLuporini FabioLuporini deleted the switch-dt2 branch June 21, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants