API: fixed callback of PrecomputedInterpolator injection #1691
+39
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloubout
changed the title
georgebisbas
requested changes
May 11, 2021
tests/test_interpolation.py
Outdated
| origin = (0, 0) | ||
| result = 0.25 | ||
|
|
||
| r = 2 # Constant for linear interpolation |
There was a problem hiding this comment.
nitpicking:
Comment should go before variable?
There was a problem hiding this comment.
I have now moved the comments before the variable
tests/test_interpolation.py
Outdated
| m = unit_box(shape=shape) | ||
| m.data[:] = 0. | ||
|
|
||
| r = 2 # Constant for linear interpolation |
There was a problem hiding this comment.
I have removed the duplicate variable
mloubout
approved these changes
May 11, 2021
Codecov Report
@@ Coverage Diff @@
## master #1691 +/- ##
===========================================
- Coverage 86.68% 57.52% -29.16%
===========================================
Files 218 202 -16
Lines 33389 31851 -1538
Branches 4342 4141 -201
===========================================
- Hits 28943 18323 -10620
- Misses 3959 12942 +8983
- Partials 487 586 +99
Continue to review full report at Codecov.
|
|
Thanks a lot, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the interpolation using PrecomputedInterpolator was working fine, the injection tries to access the
gridpointsandinterpolation_coeffsinselfinstead of inself.obj.Also, when injecting with the PrecomputedInterpolator, the preparation of the arguments for the operator calls the
self._parent._arg_defaultsfor the gridpoints SubFunction, which does not exist. By changing the parent of the SubFunction toself.objthis is solved.