compiler: Singletonize special symbols (e.g. nthreads) #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1650 +/- ##
===========================================
- Coverage 78.23% 57.30% -20.94%
===========================================
Files 215 200 -15
Lines 32697 31200 -1497
Branches 4302 4103 -199
===========================================
- Hits 25581 17878 -7703
- Misses 6595 12747 +6152
- Partials 521 575 +54
Continue to review full report at Codecov.
|
FabioLuporini
force-pushed
the
revisit-uniqueness
branch
3 times, most recently
from
71de00d to
da97d99
Compare
georgebisbas
reviewed
Apr 7, 2021
| @@ -475,8 +476,8 @@ def test_composite_buffering_tasking_multi_output(self): | |||
| assert len([i for i in symbols if isinstance(i, Lock)]) == 2 | |||
| threads = [i for i in symbols if isinstance(i, PThreadArray)] | |||
| assert len(threads) == 2 | |||
| assert threads[0].size.data == 1 | |||
| assert threads[1].size.data == 1 | |||
| assert threads[0].size.size == 1 | |||
There was a problem hiding this comment.
it's not a user-level Constant anymore. It's a Scalar, with a maxsize associated
FabioLuporini
force-pushed
the
revisit-uniqueness
branch
from
da97d99 to
7b3888f
Compare
mloubout
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.