BoundSymbol constructor to be cached #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1576 +/- ##
===========================================
- Coverage 86.26% 61.47% -24.79%
===========================================
Files 217 180 -37
Lines 31285 20378 -10907
Branches 4155 3519 -636
===========================================
- Hits 26988 12528 -14460
- Misses 3807 7247 +3440
- Partials 490 603 +113
Continue to review full report at Codecov.
|
tests/test_caching.py
Outdated
| u._C_symbol | ||
| # All u, u(inds) and u.function through u._c_symbol added to cache | ||
| assert(len(_SymbolCache) == cache_size + 3) | ||
| del u |
There was a problem hiding this comment.
same as test below force clear cache because its done at the end of the code block not start
FabioLuporini
force-pushed
the
bound-sym
branch
from
bda6cfd to
f367a6f
Compare
|
manually triggered CI-gpu: green merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1575
Switch from
__init_finalizeto__new__to make sure the extrau.functionis cought by the cache and added extra line toclear_cachetest to test it (breaks on master)