tests: Add optimizations to linalg examples #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1529 +/- ##
===========================================
- Coverage 86.67% 59.92% -26.76%
===========================================
Files 218 202 -16
Lines 33225 31835 -1390
Branches 4326 4140 -186
===========================================
- Hits 28799 19077 -9722
- Misses 3940 12169 +8229
- Partials 486 589 +103
Continue to review full report at Codecov.
|
georgebisbas
changed the title
mloubout
reviewed
Dec 10, 2020
.github/workflows/examples.yml
Outdated
| python examples/misc/linalg.py mat-mat-sum --optimize | ||
| python examples/misc/linalg.py mat-mat --optimize | ||
| python examples/misc/linalg.py mat-vec --optimize | ||
| python examples/misc/linalg.py transpose-mat-vec --optimize |
There was a problem hiding this comment.
Checks the linalg with advanced, it was noop only before.
FabioLuporini
approved these changes
Dec 15, 2020
FabioLuporini
requested changes
Dec 16, 2020
georgebisbas
force-pushed
the
misc_linalg
branch
from
ef88733 to
84c4e18
Compare
georgebisbas
force-pushed
the
misc_linalg
branch
3 times, most recently
from
9294403 to
4c0b0c7
Compare
|
Temporarily on hold due to: #1528 |
georgebisbas
force-pushed
the
misc_linalg
branch
2 times, most recently
from
34c7cdd to
b49ca62
Compare
georgebisbas
force-pushed
the
misc_linalg
branch
from
b49ca62 to
24404ad
Compare
georgebisbas
force-pushed
the
misc_linalg
branch
2 times, most recently
from
fc984b1 to
d25b756
Compare
georgebisbas
changed the title
georgebisbas
force-pushed
the
misc_linalg
branch
from
843ac3d to
0b904b3
Compare
examples/misc/linalg.py
Outdated
| @@ -24,7 +24,7 @@ def callback_shape(ctx, param, value): | |||
|
|
|||
| def callback_opts(ctx, param, value): | |||
| if value is True: | |||
| return ('blocking', 'simd', 'openmp', {'blockinner': True}) | |||
| return 'advanced' | |||
There was a problem hiding this comment.
this is not doing the same blocking/simd as master, because blockinner: True is dropped. Why?
There was a problem hiding this comment.
I vaguely remember that we talked about this in the past, maybe I am wrong....hmmm.. or it was due to the fact that no blocking happening nevertheless? Anyway reinstated.
georgebisbas
changed the title
FabioLuporini
requested changes
Apr 29, 2021
georgebisbas
force-pushed
the
misc_linalg
branch
from
5662434 to
8e2124c
Compare
FabioLuporini
changed the title
FabioLuporini
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add testing for advanced mode to Linear algebra examples