Fixup _hoist_halospots #1496
Merged
Fixup _hoist_halospots #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabioLuporini
added
minor-patch
MPI
FabioLuporini
force-pushed
the
patch-cire-minstorage-mpi
branch
from
82cf3af to
6269ab9
Compare
mloubout
approved these changes
Nov 6, 2020
| @@ -91,7 +91,7 @@ def rule1(dep, candidates): | |||
|
|
|||
| for f in hs.fmapper: | |||
| for n, i in enumerate(iters): | |||
| candidates = set().union(*[i.dim._defines for i in iters[n:]]) | |||
| candidates = [i.dim._defines for i in iters[n:]] | |||
There was a problem hiding this comment.
no, ._defines is a set and the check now works at level of each ._defines set, not the cumulative set
Codecov Report
@@ Coverage Diff @@
## master #1496 +/- ##
===========================================
- Coverage 86.52% 61.45% -25.08%
===========================================
Files 197 122 -75
Lines 28525 15385 -13140
Branches 3878 2902 -976
===========================================
- Hits 24682 9455 -15227
- Misses 3409 5386 +1977
- Partials 434 544 +110
Continue to review full report at Codecov.
|
FabioLuporini
force-pushed
the
patch-cire-minstorage-mpi
branch
from
6269ab9 to
bd88a53
Compare
mloubout
approved these changes
Nov 9, 2020
rhodrin
approved these changes
Nov 10, 2020
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1491