Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup _drop_halospots #1495

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Fixup _drop_halospots #1495

merged 2 commits into from
Nov 9, 2020

Conversation

FabioLuporini
Copy link
Contributor

fixes #1490

@FabioLuporini FabioLuporini added minor-patch MPI mpi-related compiler bug-C bug in the generated code labels Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #1495 (89d7e57) into master (dc504d6) will decrease coverage by 21.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1495       +/-   ##
===========================================
- Coverage   86.52%   64.63%   -21.89%     
===========================================
  Files         197      113       -84     
  Lines       28506    15627    -12879     
  Branches     3875     2876      -999     
===========================================
- Hits        24664    10101    -14563     
- Misses       3408     5023     +1615     
- Partials      434      503       +69     
Impacted Files Coverage Δ
devito/passes/iet/mpi.py 64.74% <100.00%> (-34.60%) ⬇️
devito/builtins.py 11.57% <0.00%> (-79.17%) ⬇️
devito/core/autotuning.py 12.77% <0.00%> (-77.10%) ⬇️
devito/passes/clusters/aliases.py 20.75% <0.00%> (-75.61%) ⬇️
devito/mpi/routines.py 23.02% <0.00%> (-72.14%) ⬇️
devito/finite_differences/coefficients.py 18.34% <0.00%> (-70.45%) ⬇️
devito/data/utils.py 23.14% <0.00%> (-69.44%) ⬇️
devito/core/operator.py 37.93% <0.00%> (-62.07%) ⬇️
devito/data/data.py 47.01% <0.00%> (-47.43%) ⬇️
tests/conftest.py 38.65% <0.00%> (-46.22%) ⬇️
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc504d6...ffe195a. Read the comment docs.

if d in hs.dimensions and all(i.is_Sequential for i in v):
flag = True
break
if flag:
Copy link
Contributor

@mloubout mloubout Nov 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need that flag?

for d, v in dmapper.items():
    if d in hs.dimensions and all(i.is_Sequential for i in v):
          mapper[hs].update(set(hs.functions))
          break

doesn't this do the same?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes ! I'm an idiot -- basically some leftover from some more complicated code I had before. Just running tests locally with your version. Will push the update if all remains green (as it should!)

@FabioLuporini FabioLuporini merged commit 4874e7d into master Nov 9, 2020
@FabioLuporini FabioLuporini deleted the patch-cire-rotate-mpi branch November 9, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-C bug in the generated code compiler MPI mpi-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cire advanced option does not generate MPI code
2 participants