-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup _drop_halospots #1495
Fixup _drop_halospots #1495
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1495 +/- ##
===========================================
- Coverage 86.52% 64.63% -21.89%
===========================================
Files 197 113 -84
Lines 28506 15627 -12879
Branches 3875 2876 -999
===========================================
- Hits 24664 10101 -14563
- Misses 3408 5023 +1615
- Partials 434 503 +69
Continue to review full report at Codecov.
|
devito/passes/iet/mpi.py
Outdated
if d in hs.dimensions and all(i.is_Sequential for i in v): | ||
flag = True | ||
break | ||
if flag: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need that flag?
for d, v in dmapper.items():
if d in hs.dimensions and all(i.is_Sequential for i in v):
mapper[hs].update(set(hs.functions))
break
doesn't this do the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes ! I'm an idiot -- basically some leftover from some more complicated code I had before. Just running tests locally with your version. Will push the update if all remains green (as it should!)
9cd06b7
to
89d7e57
Compare
89d7e57
to
ffe195a
Compare
fixes #1490