Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup preset #1015

Merged
merged 1 commit into from
Nov 28, 2019
Merged

cleanup preset #1015

merged 1 commit into from
Nov 28, 2019

Conversation

mloubout
Copy link
Contributor

Small model cleanup, presets are too big and make model.py a pain to navigate so moved it to preset_models.py with tiny bit of cleanup.

@FabioLuporini
Copy link
Contributor

OK

@@ -50,8 +50,8 @@ def run(shape=(50, 50), spacing=(20.0, 20.0), tn=1000.0,
def test_elastic():
_, _, _, [rec1, rec2, v, tau] = run()
norm = lambda x: np.linalg.norm(x.data.reshape(-1))
assert np.isclose(norm(rec1), 29.8925, atol=1e-3, rtol=0)
assert np.isclose(norm(rec2), 1.20394, atol=1e-3, rtol=0)
assert np.isclose(norm(rec1), 29.6567, atol=1e-3, rtol=0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this change is dictated by some minor changes you've made to the preset models

@FabioLuporini FabioLuporini merged commit 7769048 into master Nov 28, 2019
@FabioLuporini
Copy link
Contributor

Merged.

@FabioLuporini FabioLuporini deleted the model-cleanup branch November 28, 2019 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants