Skip to content

FEAT: Remove API layer default for groupby.get_group() (#70) [should upstream] #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvashishtha merged 1 commit into from
Feb 22, 2023
Merged

FEAT: Remove API layer default for groupby.get_group() (#70) [should upstream] #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modin/core/execution/client/query_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,6 +949,7 @@ def forwarding_method(self, by, *args, **kwargs):
"tail",
"nth",
"ngroup",
"get_group",
"std",
"sem",
"rank",
Expand Down
9 changes: 8 additions & 1 deletion modin/pandas/groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,13 @@ def var(self, ddof=1):
)

def get_group(self, name, obj=None):
return self._default_to_pandas(lambda df: df.get_group(name, obj=obj))
return self._check_index(
self._wrap_aggregation(
qc_method=type(self._query_compiler).groupby_get_group,
numeric_only=False,
agg_kwargs=dict(name=name, obj=obj),
)
)

def __len__(self):
return len(self.indices)
Expand Down Expand Up @@ -1333,6 +1339,7 @@ def nsmallest(self, n=5, keep="first"):
)
)


if IsExperimental.get():
from modin.experimental.cloud.meta_magic import make_wrapped_class

Expand Down