Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Updated geckodriver #830

Merged
merged 1 commit into from
Aug 29, 2021
Merged

Conversation

Thomas-Boi
Copy link
Member

@Thomas-Boi Thomas-Boi commented Aug 29, 2021

New feature section

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format New Feature: a brief description of feature

This PR adds/fixes

Updated the geckodriver to the latest version.

Notes

Script has been tested in my forked repo and everything still works (see this). The only issue is caused by #828 and will be fixed by #829.

@Thomas-Boi Thomas-Boi changed the title Updated geckodriver New Feautre: Updated geckodriver Aug 29, 2021
@Thomas-Boi Thomas-Boi changed the title New Feautre: Updated geckodriver New Feature: Updated geckodriver Aug 29, 2021
@Panquesito7 Panquesito7 added bug Use this label for pointing out bugs devops Use this label for devops related enhancements labels Aug 29, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for fixing this bug, @Thomas-Boi! 😄👍

@Panquesito7 Panquesito7 requested a review from amacado August 29, 2021 15:50
@amacado amacado merged commit 14151fd into develop Aug 29, 2021
@amacado amacado deleted the thomas/feature/geckodriverUpdate branch August 29, 2021 23:10
This was referenced Sep 7, 2021
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…verUpdate

New Feature: Updated geckodriver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Use this label for pointing out bugs devops Use this label for devops related enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants