Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: nuxtjs (original, original-wordmark, plain, plain-wordmark) #743

Merged
merged 15 commits into from
Jul 13, 2021

Conversation

FlorianEagox
Copy link
Contributor

Added NuxtJS SVG icons from the official website: https://nuxtjs.org/design
Created the wordmark version based on their homepage icon.
Addresses issues #736

@FlorianEagox FlorianEagox mentioned this pull request Jul 10, 2021
@FlorianEagox FlorianEagox changed the title new icon: nuxtjs (original, original-wordmark, plain, plain-wordmark new icon: nuxtjs (original, original-wordmark, plain, plain-wordmark) Jul 10, 2021
@Thomas-Boi Thomas-Boi changed the base branch from master to develop July 10, 2021 19:08
@Thomas-Boi
Copy link
Member

Hi @TheFoxarmy,

Welcome to Devicon 😄. Before we continue, there's something we need to change for this PR. Currently, it includes both the changes for nuxtjs and socketio. Please make it so that only nuxtjs changes (devicon.json, SVG files) are present in this PR please.

@FlorianEagox
Copy link
Contributor Author

Thank you, I just noticed this! I accidentally made both additions on master. I moved the last commit, The socketio one to its own branch, and committed that for the other PR, but for this, I just need to remove the latest commit on master.

@github-actions
Copy link
Contributor

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/nuxtjs/nuxtjs-original-wordmark.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/nuxtjs/nuxtjs-original.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/nuxtjs/nuxtjs-plain-wordmark.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/nuxtjs/nuxtjs-plain.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/socketio/socketio-original-wordmark.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/socketio/socketio-original.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/nuxtjs/nuxtjs-original-wordmark.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/nuxtjs/nuxtjs-original.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

@Thomas-Boi Thomas-Boi added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 10, 2021
@FlorianEagox
Copy link
Contributor Author

I have converted all icons to use 128x viewbox and removed the socketio changes from the master branch

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good work!

icons/nuxtjs/nuxtjs-original-wordmark.svg Show resolved Hide resolved
icons/nuxtjs/nuxtjs-original.svg Show resolved Hide resolved
icons/nuxtjs/nuxtjs-plain-wordmark.svg Show resolved Hide resolved
icons/nuxtjs/nuxtjs-plain.svg Show resolved Hide resolved
@FlorianEagox
Copy link
Contributor Author

FlorianEagox commented Jul 11, 2021

Hi @Panquesito7, I see these changes, and they appear to just make the icons smaller when I preview them. However, going through several other icons, they seem to take up the full size of the page just as mine did before the suggested changes. Why should I use these versions?

@Panquesito7
Copy link
Member

they appear to just make the icons smaller when I preview them

Ah, that's because the width and the height are set to 128. You can remove that, but I recommend doing it that way. 🙂

@Panquesito7 Panquesito7 linked an issue Jul 12, 2021 that may be closed by this pull request
@Thomas-Boi
Copy link
Member

Thomas-Boi commented Jul 12, 2021

Hey @Panquesito7,

We actually don't need the width and height attributes. It makes styling the SVG harder since it now restricts the SVG forever at 128px if someone uses inline SVG. We want them to scale base on the container that they are in instead. It's fine if the SVG has the width and height attribute for now. However, the svg-optimizer bot will remove it later so it doesn't matter.

I'll update the CONTRIBUTING.md so this change is reflected.

EDIT: The CONTRIBUTING was properly updated. The changes just haven't been merged to master

@Thomas-Boi Thomas-Boi added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jul 12, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Error found in 'devicon.json' for 'nuxtjs' entry: 
- missing key: 'svg' in 'versions'.
- missing key: 'font' in 'versions'.
- missing key: 'aliases'.

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to make some update to the devicon.json

devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Show resolved Hide resolved
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 13, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work, @TheFoxarmy; thank you! 👍 🎉

@Panquesito7 Panquesito7 merged commit 82b02cc into devicons:develop Jul 13, 2021
@amacado amacado mentioned this pull request Aug 14, 2021
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…devicons#743)

* Bump hosted-git-info from 2.8.8 to 2.8.9

Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <[email protected]>

* Bump lodash from 4.17.20 to 4.17.21

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <[email protected]>

* Added nuxt icon from their design guide
created new logo + text icon

* Created plain version of nuxtjs & optimized original

* removed unnecessary XML declarations.

* Changed viewbox to 128x for all icons

* Apply suggestions from code review

Co-authored-by: Thomas Bui <[email protected]>

* Apply suggestions from code review

Co-authored-by: Thomas Bui <[email protected]>

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Thomas Bui <[email protected]>
Co-authored-by: David Leal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Request: nuxt
3 participants