-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed duplicated svgs #608
Conversation
Since |
So it works great as expected. I'm also pleasantly surprised that the ids are prefixed properly when it's already prefixed. |
Just updated the font files and the |
Just pushed a commit optimizing the |
new_icons.png | ||
screenshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing an endline.
screenshots | |
screenshots | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support the idea of reducing the overall size by removing duplicates. But since this is a breaking change I would like to discuss if it's worth it. On one hand we have the reduced file size on the other hand it could break existing applications when someone (like me) is using the icons in an automated way. How much space do we save when removing those icons?
Not a lot actually. The files are between 1 kB to 4 kB so I'll use 2 kB per file. There are 12 files removed => |
@amacado I think you are right. The file savings are not a lot but the potential backwards compatibility issue might be worth more. I'm cool if you want to close this PR. I'll make another one for the other fixes. |
This removes the duplicates listed in #607.
Notes:
python-original.svg
screenshots
folder to.gitignore
. This is probably created due to one of the build steps