-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: zig (original, original-wordmark, plain-wordmark) #587
Conversation
I think the white color should be fine. If needed, I think people can modify the svg the change the color. |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
Good job @AtomToast , I'll merge your files in as soon as possible. Currently, we are adding a new workflow that update the ids of each file to prevent clashing when using inline svg. Once that is finished, we will merge your PR (should be in a few days). |
So good news: we've decided to postpone the update for a few days. In short, we are trying to update the svgs in our repo so it's optimized and has an unique id within the whole repo. Since we will have to do this for the whole repo, we can accept your PR and update your svgs then rather than do it now. In summary: Thank you for the icons @AtomToast ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The svgs and icons look great
new icon: zig (original, original-wordmark, plain-wordmark)
solves #543
I am unsure whether it is better to use the dark or light as the original-wordmark (one has black font, the other one white font). I decided to go for the light version as I expect most people to use dark themes. However I am happy to change this upon further input