-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: TheAlgorithms (original, original-wordmark, plain, plain-wordmark) #521
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi! Have a nice day, |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ready to be merged for me.
Offtopic: Should we figure out who can merge which changes? Right now, amacado has to handle everything but I think I can merge icon PR as well. What do you guys think?
Offtopic: Well, you have Owner access in the whole organization, so you can merge changes if they look good. I think it's OK that you can merge icon PRs. If @amacado or someone else finds an issue, they have to make another PR to fix the issue in the icon PR. TL;DR: Sounds good to me. I have fewer privileges than you and I can still merge PRs. Hope I get to understand. 🙂 |
If I configured everything right, than @Panquesito7 should be able to merge into |
new icon: TheAlgorithms (original, original-wordmark, plain, plain-wordmark)
I added a new icon for The Algorithms organization.
Thanks to @maltejur for improving and making the icons as per the repo standards. 🙂
This is how they look: