bot:build new icons, icomoon.json and devicon.css #1977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
bot/build-result
branch
from
3c08b98 to
f5df018
Compare
Snailedlt
approved these changes
Nov 6, 2023
|
Fixed description: |
lunatic-fox
requested changes
Nov 6, 2023
There was a problem hiding this comment.
After taking a look I found some issues and here they are classified by priority.
🟥 Major issues
Invisible, non-existent or old versioned icon
- codepen:
- font.plain-wordmark: invisible
- crystal:
- font.original-wordmark: old version
- gimp:
- font.plain-wordmark: none
- laravel:
- font.plain: old version
- font.plain-wordmark: old version and a strike line
- svg.original: new version / tilted to the right
- svg.plain: old version
- svg.plain-wordmark: old version
- msdos:
- font.plain: none
- sonarqube:
- font.plain-wordmark: none
# Needs a "plain-wordmark" version based on "original-wordmark".
- traefikmesh:
- svg.line: none
- svg.line-wordmark: none
- traefikproxy:
- svg.line: none
- svg.line-wordmark: none
- vercel:
- font.original-wordmark: old version🟨 Minor issues
SVG version tilted to the right
The icon is displaying correctly, but they don't fit in the square where they suppose to be.
This can be an error exclusively on my side.
Does not affect the proper use of the icon.
- codeac:
- original
- contao:
- original
- original-wordmark
- cosmodb:
- original
- original-wordmark
- cypressio:
- original
- original-wordmark
- fortran:
- original
- havester:
- original
- original-wordmark
- influxdb:
- original
- original-wordmark
- junit:
- original
- original-wordmark
- k3os:
- original
- original-wordmark
- livewire:
- original
- original-wordmark
- llvm:
- original
- mobx:
- original
- plain
- mongoose:
- original
- original-wordmark
- nim:
- original
- original-wordmark
- nimble:
- original
- plain
- norg:
- original
- plain
- okta:
- original
- original-wordmark
- openapi:
- original
- original-wordmark
- purescript:
- original
- original-wordmark
- rancher:
- original
- original-wordmark
- reach:
- original
- plain
- scalingo:
- original
- original-wordmark
- sema:
- original
- original-wordmark
- vercel:
- original
- original-wordmark
- vertx:
- original
- original-wordmark
- vsphere:
- original
- original-wordmark
- xml:
- original🟨 Miscellaneous
- svelte:
- svg.original-wordmark:
The styled "S" seems a little bit squished.
- svg.plain-wordmark:
The styled "S" seems a little bit squished.
- towergit:
- font.plain-wordmark:
Part of the tower's wall seems to be invisible.
- weblate:
- font.plain-wordmark:
Some detail of the styled "W" is missing.
|
@lunatic-fox great finds! |
|
To fix the ones that have The I think having an old icon is okay for now, that can be updated in a new minor release. The same goes for icons that are off-center and other minor issues. As a sidenote I also found that the unity-line-wordmark version has some artifacts in the corners of the logo. |
|
I suggest we make issues for the lower priority ones, and fix the higher priority ones before the release. |
This was referenced Nov 6, 2023
Merged
Merged
Merged
That's exactly what I was thinking. |
6 tasks
|
@lunatic-fox Great, thanks for adding that list. It really sped up the reviewing process for me! |
|
Here's the artifacts I found for the unity line versions btw: I'll see if I can get it fixed today |
Merged
6 tasks
|
Alright, all the critical PR's are merged now. I'll try to build icons again and see how it goes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm Devicon's Build Bot and I just built some new font files and devicon.min.css file.
Here are all the SVGs that were uploaded (the new ones are those with highlight):
Here is what they look like as icons:
The devicon.min.css file contains:
-The icon content
-The aliases
-The colored classes
I also compiled a list of new features and icons that were added since last release.
More information can be found in the GitHub Action logs for this workflow.
Adios,
Build Bot 😎