-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Magento, Shopware, Salesforce, vue StoreFront icons #193
Conversation
Adding SalesForce icons
vue StoreFront icons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. Please take a look at our updated contribution guidelines and pay special attention to:
- Create a separated pull request for each icon (no matter how many variations)
- Modify devicon.json to include the icon (or variations)
- Modify devicon-colors.css to include the colored version of the icon
Hello there,
Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before. We hope to see your icons in the Devicon repo soon :) Cheers, |
Hello there, We notice that this PR has been inactive for awhile now. It would be a waste of your time and effort if we just close this PR and throw away the SVGs in here. Thus, 1 month from now, if this PR remains inactive/stale, we will fork your repo, fix any issues, and merge your icons ourselves. Since GitHub tracks contributions by commits, you will still be credited. We also hope that you will help us merge this PR before the deadline comes. Cheers, |
Hey @mariaavideva, Are you still planning to work on this or should I take it over? Our commit policy has changed a lot so I can also help you with the changes. |
Hello @mariaavideva, This PR has been split into 4 PRs listed above. I had to remove the |
No description provided.