Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for iPhone 16 models and Apple Watch Series 10. #417

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

Zandor300
Copy link
Member

Add support for iPhone 16 models and Apple Watch Series 10.

@Zandor300 Zandor300 self-assigned this Sep 10, 2024
Copy link

github-actions bot commented Sep 10, 2024

12 Warnings
⚠️ Plist changed, don't forget to localize your plist values
⚠️ Source/Device.generated.swift#L682 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:682
⚠️ Source/Device.generated.swift#L1235 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1235
⚠️ Source/Device.generated.swift#L1487 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1487
⚠️ Source/Device.generated.swift#L1653 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1653
⚠️ Source/Device.generated.swift#L1799 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1799
⚠️ Source/Device.generated.swift#L2476 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:2476
⚠️ Source/Device.generated.swift#L2535 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:2535
⚠️ Tests/Tests.swift#L491 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:491
⚠️ Tests/Tests.swift#L562 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:562
⚠️ Tests/Tests.swift#L648 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:648
⚠️ Tests/Tests.swift#L680 - Collection literals should not have trailing commas.
trailing_comma Tests.swift:680

SwiftLint found issues

Warnings

File Line Reason
Tests.swift 460 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 491 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 522 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 562 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 648 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 680 Collection literals should not have trailing commas. (trailing_comma)
Device.generated.swift 682 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1235 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1487 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1653 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1799 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 2476 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 2535 TODOs should be resolved (Replace with proper implementa...). (todo)

Generated by 🚫 Danger

@t9mike
Copy link

t9mike commented Sep 12, 2024

I noticed iPhone16 placeholders still in mapToDevice:

  case "iPhoneTODO1": return iPhone16
  case "iPhoneTODO2": return iPhone16Plus
  case "iPhoneTODO3": return iPhone16Pro
  case "iPhoneTODO4": return iPhone16ProMax

@duke4e
Copy link

duke4e commented Sep 13, 2024

we can get the phone string via simulators:

case "iPhone17,3": return iPhone16
case "iPhone17,4": return iPhone16Plus
case "iPhone17,1": return iPhone16Pro
case "iPhone17,2": return iPhone16ProMax

@furiosFast
Copy link
Contributor

furiosFast commented Sep 18, 2024

we can get the phone string via simulators:

case "iPhone17,3": return iPhone16 case "iPhone17,4": return iPhone16Plus case "iPhone17,1": return iPhone16Pro case "iPhone17,2": return iPhone16ProMax

for watch:

      case "Watch7,8": return appleWatchSeries10_42mm
      case "Watch7,9": return appleWatchSeries10_46mm

@arindamkb
Copy link

Please check this Wikipedia page, hardware strings of iPhone 16 series are updated here https://en.wikipedia.org/wiki/List_of_iPhone_models

@Zandor300 Zandor300 marked this pull request as ready for review September 20, 2024 10:09
@Zandor300 Zandor300 merged commit 2b43271 into master Sep 20, 2024
16 checks passed
@Zandor300 Zandor300 deleted the feature/2024-september-devices branch September 20, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants