Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building SwiftUI previews on macOS. #389

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

Zandor300
Copy link
Member

@Zandor300 Zandor300 commented Feb 6, 2024

The previous PR didn't fix the compilation errors when building SwiftUI previews on macOS properly.

Cherry picked from #379

Closes #379

Fixes #341

Thank you @honghaoz!

Copy link

github-actions bot commented Feb 6, 2024

1 Warning
⚠️ Plist changed, don't forget to localize your plist values

Generated by 🚫 Danger

@Zandor300 Zandor300 merged commit 6c01329 into master Feb 6, 2024
16 checks passed
furiosFast added a commit to furiosFast/DeviceKit that referenced this pull request May 31, 2024
* master:
  Version bump. (v5.4.0)
  Add unknown orientation variant (devicekit#411)
  Version bump. (v5.3.1)
  Fix path for PrivacyInfo.xcprivacy in test target.
  Process Privacy manifest instead of copy on SPM. (devicekit#409)
  Version bump. (v5.3.0)
  Support for new May 2024 devices. (devicekit#412)
  Fix ruby version not found. (devicekit#414)
  Version bump. (v5.2.4)
  Enable MERGEABLE_LIBRARY. (devicekit#407)
  Update cocoapods to v1.15.2 in Gemfile.
  Release 5.2.3
  fix: Use cocoapod resource_bundles for PrivacyInfo (devicekit#397)
  Fix building for visionOS.  (devicekit#390)
  Fix building SwiftUI previews on macOS. (devicekit#389)
  Release 5.2.1 (devicekit#385)
  Fix PrivacyInfo.xcprivacy not being detected on SPM. (devicekit#384)
  Update swift-tools-version in Package.swift to 5.3 to support Resource files. (devicekit#381)

# Conflicts:
#	Source/Device.swift.gyb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed SwiftUI preview on macOS
2 participants