Add new iPhone 15 Series to DeviceKit #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Johannes Ebeling <[email protected]>
Co-Authored-By: Johannes Ebeling <[email protected]>
Co-Authored-By: Johannes Ebeling <[email protected]>
|
Maybe new watches should be added as well |
|
I thought I'd add them separately so there's not a huge PR coming in. |
|
@LaurentiuUngur I added them with a new PR, #361 |
ovidiuadorian-yonder
approved these changes
Sep 16, 2023
|
@wo-ist-henry Apple is using "telephoto camera" to describe the 5x lens on iPhone 15 Pro Max, so I think it is best to stick to that. I might be better to add extra functionality to DeviceKit to check how much zoom the device's telephoto camera is:
But that is for another time, first need to add support for the devices. I cherrypicked your PR into a release PR, I will change it back to telephoto for now over there. #362 |
Merged
|
Cherrypicked this PR into #362 |
|
Merged to master through #362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ne the iPhone Series, also added the new camera type Periscope to differentiate between the zoom capabilities that the iPhone 15 Pro Max and all the others has.