fix: truncated profile error messages #2524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Here's is how to fix looks on the UI:
|
rsdmike
previously approved these changes
Mar 3, 2025
rsdmike
changed the title
rsdmike
changed the title
Member
|
@DanielMoya-Intel looks like just a |
Before the fix, when creating a new profile, if validation or other errors occurred, the informational messages at the top were truncated. Fixes device-management-toolkit#2486 Signed-off-by: Moya Sanchez, Daniel <[email protected]> Signed-off-by: Byron Marohn <[email protected]> Signed-off-by: Baltodano Zamora, Jefry <[email protected]> Signed-off-by: Vela, Mano <[email protected]>
auto-merge was automatically disabled
March 4, 2025 00:44
Head branch was pushed to by a user without write access
agustinfrancesa
force-pushed
the
fix/truncated-profile-notices-2468
branch
from
8c9f6ff to
fa38b31
Compare
Contributor
|
Fix prettier validation errors, by commit amend |
rsdmike
approved these changes
Mar 4, 2025
|
🎉 This PR is included in version 3.32.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What are you changing?
Before the fix, when creating a new profile, if validation or other errors occurred, the informational messages at the top were truncated.
Fixes #2486
Anything the reviewer should know when reviewing this PR?
Tested manually by locally running the UI.