-
Notifications
You must be signed in to change notification settings - Fork 5
Closed
Labels
Description
🔹 Overview
The go-wsman-messages repository currently depends on 99designs/keyring, which doesn't seem to be actively maintained. We need to replace it with zalando/go-keyring, a well-maintained and actively supported alternative for secure credential storage.
This will ensure that the project remains up-to-date, secure, and free from unmaintained dependencies.
🎯 Task Scope
- Step 1: Remove
99designs/keyringfromgo.modandgo.sum. - Step 2: Add
zalando/go-keyringas a new dependency. - Step 3: Update any existing usage of
99designs/keyringto usezalando/go-keyringinstead. - Step 4: Ensure compatibility with existing functionality (e.g., credential storage/retrieval).
- Step 5: Run tests and confirm that keyring functionality remains intact.
- Step 6: Clean up and optimize any redundant code related to the keyring migration.
📂 Relevant Files
go.modgo.sum- Any files that import
"github.com/99designs/keyring"
💻 Technical Details
zalando/go-keyringprovides a similar API but may require slight modifications in function calls.- Ensure that credential storage and retrieval work seamlessly with:
- Windows Credential Store
- macOS Keychain
- Linux Secret Service
- Run
go mod tidyafter replacing the dependency. - Team can help with testing other platforms if you don't have all available.
✅ Acceptance Criteria
- The project no longer depends on
99designs/keyring. -
zalando/go-keyringis successfully integrated. - All keyring-related functionality remains working and tested.
- No breaking changes or regressions.
- A Pull Request (PR) is submitted with a summary of changes.
🚀 How to Get Started
- Comment below to claim this issue.
- Fork the repo and create a branch (e.g.,
feature/replace-keyring). - Implement the feature following the outlined scope.
- Submit a Pull Request (PR) linking this issue.
📎 Additional Notes
- Ensure
go test ./...runs successfully after changes. - Check the documentation for
zalando/go-keyringfor any differences in implementation. - Test on multiple OS platforms if possible to ensure cross-platform compatibility.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Done
Status
Q3 2025