Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes from passwords #678

Closed
wants to merge 1 commit into from
Closed

Conversation

pleeplop
Copy link

@pleeplop pleeplop commented Mar 1, 2022

In my environment default passwords don't work because single quotes are not removed.
So the password for Kibana web UI is 'changeme' but it should be changeme as explained in the README

Environment:
Ubuntu 20.04.3 LTS
docker-compose version 1.25.0
Docker version 20.10.7

@antoineco
Copy link
Collaborator

antoineco commented Mar 1, 2022

@pleeplop thanks for the suggestion 🙌

That is a known issue with Compose versions below v1.26.0. For this reason, we only support Compose v1.26.0 and above.

Extract from the README:

Host setup

Versions between v1.22.0 and v1.25.5 are known to work as well, but require omitting quotes like you suggested:

# .env
ELASTIC_VERSION=8.0.0
ELASTIC_PASSWORD=changeme
LOGSTASH_INTERNAL_PASSWORD=changeme
KIBANA_SYSTEM_PASSWORD=changeme

I have to reject this PR because we don't want to remove quotes from the default .env file for the following reasons:

  1. bin/elasticsearch-reset-password generates passwords with special characters ($#?!=...), which makes quoting necessary in some cases (see Kibana exits due to changed password in config #667).

    For example, an .env file with unquoted values containing special characters would cause issues with tools that read .env files using a shell (such as direnv)

  2. This is only an issue with unsupported versions of Compose.

    v1.25.0 is two years old and we can't possibly keep supporting old versions forever. The issue with .env files is one reason for this. Bumping the format version of Compose files is another one.

A few references:

@pleeplop
Copy link
Author

pleeplop commented Mar 1, 2022

It makes sense.
Thank you for the feedback.

@pleeplop pleeplop closed this Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants