Add metadata to fifo pipe output #203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add /daemon /go-librespot
|
This is the config.yml I have been using: |
devgianlu
requested changes
Sep 10, 2025
| "google.golang.org/protobuf/proto" | ||
| ) | ||
|
|
||
| // Update extractMetadataFromStream method signature: |
| } | ||
| } | ||
|
|
||
| return title, artist, album, trackID, duration, artworkURL, artworkData |
There was a problem hiding this comment.
We should not be returning that many values
Comment on lines
+167
to
+173
| /* | ||
| if p.primaryStream != nil { | ||
| title, artist, album, trackID, duration, artworkURL := p.extractMetadataFromStream(p.primaryStream) | ||
| p.app.log.Debugf("Sending metadata: %s by %s", title, artist) | ||
| p.UpdateTrack(title, artist, album, trackID, duration, true, artworkURL) // true = playing | ||
| } | ||
| */ |
There was a problem hiding this comment.
Can this be definitely removed?
|
|
||
| p.UpdatePlayingState(true) | ||
|
|
||
| // Add this line to update position on resume |
|
|
||
| p.sess.Events().PostPrimaryStreamLoad(p.primaryStream, paused) | ||
|
|
||
| // In loadCurrentTrack method: |
| drop bool | ||
| } | ||
|
|
||
| // Update MetadataCallback interface: |
Comment on lines
+10
to
+11
| /daemon | ||
| /go-librespot |
There was a problem hiding this comment.
I guess these are because you are cross-compiling, but they are a bit misleading
|
|
||
| _, err := fm.pipe.Write(data) | ||
| if err != nil { | ||
| // Close and attempt to reopen on error |
There was a problem hiding this comment.
Doesn't seem reconnection happens on error
Comment on lines
+98
to
+105
| switch fm.format { | ||
| // case "json": | ||
| // data = metadata.ToJSONFormat() | ||
| case "xml": // ADD THIS CASE | ||
| data = metadata.ToXMLFormat() | ||
| //default: // "dacp" | ||
| // data = metadata.ToDACPFormat() | ||
| } |
There was a problem hiding this comment.
These should be supported right?
| } | ||
|
|
||
| // Update UpdateTrack method signature: | ||
| func (pm *PlayerMetadata) UpdateTrack(title, artist, album, trackID string, duration time.Duration, playing bool, artworkURL string, artworkData []byte) { |
There was a problem hiding this comment.
Perhaps we can use a struct here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metadata to fifo pipe output as requested in: Add metadata output to a pipe as it is in librespot-java #157
Functionally this works very well showing track info, duration and timing, and artwork when piped into owntone and the Home Assistant dashboard when running when running in an addon.
I used AI to help write it and don't see any issues at this point. This is my first pull request so I expect there will be nits and other issues, but I will do will what I can to help push this forward.