feature: pagefind in public page #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdxker
force-pushed
the
cd/pagefind-in-publicpage
branch
from
0541420 to
a4fff9c
Compare
cdxker
commented
Dec 20, 2024
server/src/bin/ingestion-worker.rs
Outdated
Comment on lines
264
to
310
| if dataset_config.PAGEFIND_ENABLED { | ||
| let pagefind_worker_message = PagefindIndexWorkerMessage { | ||
| dataset_id: payload.dataset_id, | ||
| created_at: chrono::Utc::now().naive_utc(), | ||
| attempt_number: 0, | ||
| }; | ||
|
|
||
| let serialized_message = | ||
| serde_json::to_string(&pagefind_worker_message).map_err(|_| { | ||
| ServiceError::InternalServerError( | ||
| "Failed to serialize message".to_string(), | ||
| ) | ||
| }); | ||
|
|
||
| let maybe_redis = redis_pool | ||
| .get() | ||
| .await | ||
| .map_err(|err| ServiceError::BadRequest(err.to_string())); | ||
|
|
||
| let response: Result<(), ServiceError> = match (serialized_message.clone(), maybe_redis) { | ||
| (Ok(message), Ok(mut redis_conn)) => { | ||
| redis::cmd("lpush") | ||
| .arg("pagefind-index-ingestion") | ||
| .arg(&message) | ||
| .query_async::<_, ()>(&mut *redis_conn) | ||
| .await | ||
| .map_err(|err| ServiceError::BadRequest(err.to_string())) | ||
| .map(|_| ()) | ||
| }, | ||
| (Err(serial_error), Ok(_)) => { | ||
| Err(ServiceError::InternalServerError(format!("couldn't get serialized message {:?}", serial_error))) | ||
| } | ||
| (Ok(_), Err(redis_error)) => { | ||
| Err(ServiceError::InternalServerError(format!("couldn't get redis conn {:?}", redis_error))) | ||
| } | ||
| (Err(serial_error), Err(redis_error)) => { | ||
| Err(ServiceError::InternalServerError(format!("couldn't get serialize message and couldn't redis conn {:?} {:?}", serial_error, redis_error))) | ||
| } | ||
| }; | ||
|
|
||
| match response { | ||
| Ok(_) => log::info!("Queue'd dataset for pagefind indexing"), | ||
| Err(e) => log::error!("Failed to start pagefind indexing {:?}", e) | ||
| } | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
Currently we auto trigger a full pagefind reingest, anytime a batch of chunks is updated, we will likely move this logic, if we get charged too much
cdxker
force-pushed
the
cd/pagefind-in-publicpage
branch
from
434a445 to
adcb79e
Compare
server, easier to distribute and rebalance
cdxker
force-pushed
the
cd/pagefind-in-publicpage
branch
from
adcb79e to
d2f385e
Compare
skeptrunedev
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a pagefind option onto public page settings.
This does require new env's mainly. We have an s3 bucket that we use internally, PM me for the ACCESS_KEY and SECRET_KEY. Afterwards, your index will be able to get uploaded into the bucket.